search

kevinaangstadt / CS340-Summer21-Notes

Lecture notes from SLU CS-340 Summer 2021
0 stars 4 forks source link

AssignNotes 'Review' column #57

Open superslalomracer opened 3 years ago

superslalomracer commented 3 years ago

I was updating the AssignNotes.md file and I realized that the 'reviewed' column is very unclear as to what it actually means. I wasn't sure if it referred to PR reviews or editing one another's code to fit formatting. Since the PR reviews were assigned and much more formal, I added in one of my commits to change the name of the column to "PR reviewed". Does anyone think it's more useful for it to track formatting edits? If so, just comment here or on the pull request I just submitted and I will change it if anyone has a strong opinion.

kevinaangstadt commented 3 years ago

@AlphaCentauri79 since you own this file, can you please comment?

DigitalSRC commented 3 years ago

I imagine Kevin is keeping his own way to keep track of PR reviews, this was more for when you did a PR for someone else's work after reviewing it and editing something on it.

So to clarify Kevin's PR reviews are separate. The AssignNotes.md is solely for internal file checks. So you need to have your name there 3 times I believe.

superslalomracer commented 3 years ago

Okay, I see what you mean. At this point I don't think its worth it to change that file, but I can see how it would've been helpful.