search

kevinadhiguna / wifi-sploit

Wi-Fi sploit is a password cracker for router's login pages (but it works fine in any login page site, even on internet :D)
82 stars 25 forks source link

Over-broad requirements definition. #1

Closed amcgregor closed 3 years ago

amcgregor commented 3 years ago

Howdy!

Was casually browsing through the dependants on one of my libraries, and noticed yours has a declared dependence on uri (by way of requirements.txt), however your library does not actually make use of uri in any way.

It's generally a good idea to clean up these after executing pip freeze to ensure only actual dependencies are included.

Exactly the same problem as per: kevinadhiguna/link-shortener#1 and kevinadhiguna/instagram-profpic-downloader#1 and kevinadhiguna/body-mass-index-calculator#1

Low quality bulk library creation with no use of the referenced libraries is pure spam. Please correct this.

kevinadhiguna commented 3 years ago

Hello @amcgregor , I really appreciate you for submitting this issue. Previously, I used pip freeze > requirements.txt but it seemed to include unused libraries as well. Therefore, I just generated a new requirements.txt in the latest commit with pipreqs. Please let me know if the issue still persists..

Also, I will try to fix the same issue in other repositories as well. Big thanks !

amcgregor commented 3 years ago

Thank you very much, and apologies for the cross-project e-mail notification spam I must have triggered; thought you may wish to individually track corrections.

Thank you again! (Time for another spam-wave. 😭) Wave 2! 😀