kevinatown / MMM-Screencast

A module to cast to the magic mirror
MIT License
166 stars 34 forks source link

Screen is still visible after disconnecting? #128

Open LupoLucario opened 2 years ago

LupoLucario commented 2 years ago

After closing the connection (via smartphone), youtube on the mirror is still visible and asks me, if I want to login or not.

Screen

A reconnection is possible and works. But I can not get rid of the window without restarting the mirror :/

Jasa1983 commented 2 years ago

Hi have the same issue.

bobsusedtires commented 2 years ago

Same. Works on my other mirror though. I'm running out of ideas. Seems like if I could click continue as guest, it'd be fine, but I already hid my mouse. lol

bobsusedtires commented 2 years ago

It is ONLY the youtube app from my phone. Every other app from phone, or computer, or whatever works fine.

vinaynaik121 commented 2 years ago

Having same issue anyone got solution for this??

mugen2220 commented 2 years ago

Anyone find a fix?

bobsusedtires commented 2 years ago

I cloned the SD from my other mirror and tried it on new hardware. Still have the screen coming up on the new one, while my old mirror is fine. Has to be something silly.,..

Davrent commented 2 years ago

Bonjour, j'ai le même souci sur une nouvelle installation. Quelqu'un à trouvé une solution ? Merci :)

Hello, I have the same problem on a new installation. Has anyone found a solution? Thanks :)

amithapa commented 2 years ago

@LupoLucario Any luck with this issue? @kevinatown any suggestion how we could get this working?

LupoLucario commented 2 years ago

I tried several things: different devices, networks and circumstances but without any luck so far.

kevinatown commented 2 years ago

Hi y'all, sorry about the delay on this, been busy with work, house, life, and some other projects. Anyways..

Some more information would be greatly appreciated, such as:

You can do the log like so: npm start >> log.log and stick that log in here? Thanks!

LupoLucario commented 2 years ago

Hi kevin,

Here is the log of starting the mirror, connecting with the phone (not playing any video), and disconnecting. For a better readability I disabled all of my other modules:

> magicmirror@2.20.0 start
> DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js

[07.08.2022 16:34.20.222] [LOG]   Starting MagicMirror: v2.20.0
[07.08.2022 16:34.20.230] [LOG]   Loading config ...
[07.08.2022 16:34.20.237] [LOG]   Loading module helpers ...
[07.08.2022 16:34.20.392] [LOG]   Initializing new module helper ...
[07.08.2022 16:34.20.394] [LOG]   Module helper loaded: MMM-Screencast
[07.08.2022 16:34.20.395] [LOG]   All module helpers loaded.
[07.08.2022 16:34.20.523] [LOG]   Starting server on port 8086 ... 
[07.08.2022 16:34.20.536] [LOG]   Server started ...
[07.08.2022 16:34.20.538] [LOG]   Connecting socket for: MMM-Screencast
[07.08.2022 16:34.20.540] [LOG]   Sockets connected & modules started ...
[07.08.2022 16:34.20.846] [LOG]   Launching application.
[07.08.2022 16:34.36.195] [LOG]   screencast stdout: 
> magicmirror-screencast@0.0.5 start
> electron app.js

[07.08.2022 16:34.38.080] [LOG]   screencast stderr: (node:18655) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information

Thank you for your help =)

goldyfruit commented 2 years ago

I got the same behavior.

Egnos87 commented 2 years ago

I have the same problem...please @kevinatown help us! Thanks

mrwertman commented 2 years ago

This is happening for me also. @kevinatown

bobsusedtires commented 2 years ago

Started happening on my other install that was working before.

Dresch360 commented 2 years ago

Having the same issue - is there a fix?

goldyfruit commented 2 years ago

I did a PR here: https://github.com/kevinatown/MMM-Screencast/pull/132 Waiting for @kevinatown to look at it.

Egnos87 commented 2 years ago

I did a PR here: #128 Waiting for @kevinatown to look at it.

Does this fork https://github.com/amirthapa27/MMM-Screencast solve the problem?

Thanks

goldyfruit commented 2 years ago

I did a PR here: #128 Waiting for @kevinatown to look at it.

Does this fork https://github.com/amirthapa27/MMM-Screencast solve the problem?

Thanks

Yes but it opens the developer tools.

You can use https://github.com/smartgic/MMM-Screencast with the fix_window_still_visible branch.

Egnos87 commented 2 years ago

I did a PR here: #128 Waiting for @kevinatown to look at it.

Does this fork https://github.com/amirthapa27/MMM-Screencast solve the problem? Thanks

Yes but it opens the developer tools.

You can use https://github.com/smartgic/MMM-Screencast with the fix_window_still_visible branch.

Ok, thanks. The other big problem (perhaps worse than the issue #128 ...) is the one described in this issue #131 , that is the impossibility to connect.

Is there a solutions?

SyedIntekhab commented 2 years ago

The connecting issue fixes itself when you do npm audit fix - - force.

But the window still visible problem creeps back in. :(

Tom-Hirschberger commented 2 years ago

I tried the fix of @goldyfruit with Raspberry OS Buster and Bullseye. In my case it works with both os versions

marsul23 commented 1 year ago

I am having the same issue. After closing the connection (via smartphone), youtube on the mirror. fix_window_still_visible branch does not solve the problem. Any ideas?

devtobi commented 1 year ago

For me, the fork of @goldyfruit fixed the error of closing the module. However, I still have connection issues after connecting to the mirror once. Only a restart of MM2 fixes the error, which means I have to restart the mirror after each screencast, which kind of sucks.

Goggite commented 11 months ago

Hello! Will here be update which hide module after translation ending?

Skyview79 commented 10 months ago

I've used the branch: fix_window_still_visible but it doesn't help my situation. The Youtube window remains open after I close the player on the phone.

Raspberry Pi 4, x64 6.1.21-v8+ MagicMirror 2.26.0

dennisklad commented 1 month ago

Hi, I just pulled the new code and I have the same issue after a fresh installation.