Fix issue #128

[goldyfruit]

This fix is inspired by https://github.com/amirthapa27/MMM-Screencast

When autoCloseScript is called, it sends a message (mmm-screencast.exited) to the console. If the message is received then an IPC is emitted as well as a call to the app.quit() method.

[Egnos87]

Hi @goldyfruit, I tried your version of MMM-Screencast but when I disconnect from sharing with MM (which I do with my smartphone) the YuoTube window is always visible. Am I wrong something?

Thanks.

[goldyfruit]

@Egnos87 works, for me. Did you try the correct branch of my fork (fix_window_still_visible)?

[Egnos87]

I did the git clone from here https://github.com/smartgic/MMM-Screencast/tree/fix_window_still_visible

When I press "Disconnect" from the YouTube app it actually disconnects but the YouTube window always remains open.

[goldyfruit]

@Egnos87 did you restart the mirror after cloning the repo?

[Egnos87]

Yes, I have tried many ways but it always remains the youtube window open. What O.S. do you have? I have Buster ...

This is my config:

{ module: 'MMM-Screencast', position: 'bottom_right', // This position is for a hidden

and not the screencast window config: { position: 'center', height: 300, width: 500, x:710, y: 200, //200 castName: 'MagicMirror' } },

[goldyfruit]

I'm running inside Debian Buster container; this is my configuration for the module:

        {
            classes: 'default',
            config: {
                castName: 'smartgic_mirror',
        position: 'center',
        height: 720,
        width: 1024
            },
            module: 'MMM-Screencast',
            position: 'middle_center'
        },

How do you do your git clone? This is how you should do it:

git clone https://github.com/smartgic/MMM-Screencast.git -b fix_window_still_visible

[goldyfruit]

@kevinatown could you please have a quick look to the PR?s I think this could help few people having the same issue. :+1:

[KristjanESPERANTO]

@goldyfruit Since @kevinatown has not responded for a long time: Would you be willing to continue the development/maintainment in your fork? Then we could change the link in the official module list to your fork and the users could profit from a working version of this nice module. What do you think?

[kevinatown]

Oh shit sorry, I ended up having a kid when this PR was added I’ll give this a look this week. Sorry for the delay, sometimes life comes at you fast.

[KristjanESPERANTO]

@kevinatown Congratulations on the kid! That, of course, is more important than any PR.

[kevinatown]

Merging and closing