kevinatown / MMM-Screencast

A module to cast to the magic mirror
MIT License
166 stars 34 forks source link

Please consider a close on timeout option #64

Open RomanOnARiver opened 4 years ago

RomanOnARiver commented 4 years ago

log.log After a set period or time with no video playing it would be nice for the video player to close. I'm running into an issue where the phone does its battery saving, disconnects from casting, and can't find the smart mirror device anymore - unable to close it I have to restart magic mirror completely.

Short of rooting the phone to disable optimization for YouTube (because it's a system app) I think a good solution would be to be able to specify in the config that after a set period, say 30 seconds of no video playing the module should close and make cast device available again.

Attached a log. First time casting work, I close it, then the second time it just stayed on the YouTube loading image and never progressed, meanwhile the device stopped appearing in the YouTube app and was unavailable as a cast destination until MagicMirror was restarted.

kevinatown commented 4 years ago

Hey @RomanOnARiver! Sorry for the late reply, I've been swamped with work and let a lot of other things go by the wayside :(.

I love this idea and will try to get to implementing this feature.

masoudl commented 4 years ago

This is a great idea. Do you think it is something that may be added in an upcoming release?