Fetch many boards - Githubissues

micaelr95 commented 4 years ago

This PR will add the ability to fetch data from multiple boards

micaelr95 commented 4 years ago

@kevinbarnett Can I get this PR merged?

kevinbarnett commented 4 years ago

Cool idea, @micaelr95 ! Here are some suggestions that I would prefer to see before considering a merge on this PR:

removing the boardToken parameter is a breaking change; please continuing to support this parameter by merging this and the boardTokens parameter in the sourceNodes method
I would also like to include a deprecation notice message for the boardToken parameter
creating a new (parent) node e.g. greenhouseBoards for the purposes of labeling / curating from multiple boards; this should be linked to all child nodes

micaelr95 commented 4 years ago

Hey @kevinbarnett . Thank you so much for the comment.

Can you elaborate on the last point?

Edit: I already added the two first points. Can you check if that's what you wanted?

kevinbarnett commented 4 years ago

@micaelr95 your changes that address the first two points look good.

On the last point, I would recommend pulling from two Greenhouse boards you are not familiar with (hint: you can look at Greenhouse's homepage and look for customer logos; these can be used to infer what the boardToken is for those customers).

After pulling from multiple boards, how can you tell which job/department/office is related or not related to the same board?

I believe a new node – greenhouseBoard – needs to be added and linked to the other nodes.

This should illustrate the use case I'm thinking of (assuming you have built a Gatsby site with multiple boards):

kevinbarnett / gatsby-source-greenhouse-job-board

Fetch many boards #2