search

kevinbeaty / fs-promise

[DEPRECATED] Use mz or fs-extra^3 with Promise support
https://www.npmjs.com/package/fs-extra
MIT License
170 stars 13 forks source link

Move Types dependencies to devDependencies #22

Closed SBD580 closed 7 years ago

SBD580 commented 7 years ago

This is causing Types conflicts as @types/fs-extra is including @types/node as well (see https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/332 for example)

RyanZim commented 7 years ago

@kevinbeaty @dcharbonnier I'm not familiar with types/TypeScript.

dcharbonnier commented 7 years ago

@RyanZim this is correct, should be merged IMO. Thx @SBD580

RyanZim commented 7 years ago

@dcharbonnier Is this semver-patch?

@kevinbeaty Can you merge and publish a new version?

kevinbeaty commented 7 years ago

Published 2.0.1

Thanks!

EddyVerbruggen commented 7 years ago

Thanks @kevinbeaty and @SBD580