search

kevinbeaty / fs-promise

[DEPRECATED] Use mz or fs-extra^3 with Promise support
https://www.npmjs.com/package/fs-extra
MIT License
170 stars 13 forks source link

Does not promisify mkdtemp #24

Closed futpib closed 7 years ago

futpib commented 7 years ago 
> require('fs-promise').mkdtemp('test')
undefined // expected Promise
RyanZim commented 7 years ago

@futpib What version of fs-promise are you using? Also, what Node.js version are you using?

futpib commented 7 years ago

@RyanZim node v7.7.4 fs-promise 2.0.1

RyanZim commented 7 years ago

Confirmed. This issue should be moved to https://github.com/normalize/mz, since they handle promisifying the native fs methods. Would you mind doing that for me? Thanks!

futpib commented 7 years ago

Well, It is apparent from sources that fs-promise does not reexport mkdtemp.

Also

> require('mz/fs').mkdtemp('test')
Promise { <pending> }
RyanZim commented 7 years ago

Oh sorry, didn't realize we had such a brittle approach to this. I'll try and fix this tonight.

kevinbeaty commented 7 years ago

Version 2.0.2 Published. Thanks!