search

kevinblighe / EnhancedVolcano

Publication-ready volcano plots with enhanced colouring and labeling
399 stars 81 forks source link

Removed dependencies on ggalt & ggrastr packages #78

Closed ericblanc20 closed 2 years ago

ericblanc20 commented 3 years ago

Hi Kevin,

Thank you for your package, it's very useful.

This merge request removes dependencies on packages ggalt & ggrastr.

These two packages were making installation of EnhancedVolcano in a singularity container very difficult. This merge request removes the formal dependencies, but keeps the features available when the packages are present.

The test for the presence of the packages is carried out using find.package. This method was selected to avoid having to load the package namespace, but it may not be the safest way to check whether a package is installed or not (according to this post).

I hope you will consider my suggestion, thanks again anyway,

Eric

kevinblighe commented 3 years ago

Hi Eric, I have no problem making these changes, provided that they don't interfere with the Bioconductor build process. I will have to test this, hopefully before the next Bioconductor release, which is coming soon.

AminMahpour commented 2 years ago

Agreed with Eric. The dependencies are an absolute nightmare on HPCs.

kevinblighe commented 2 years ago

Fair enough, I have just approved them

kevinblighe commented 2 years ago

Thank you very much for the kind code suggestions, @ericblanc20