kevinboone / solunar2

A command-line utility for Linux, for display sunrise/set and similar information
GNU General Public License v3.0
18 stars 3 forks source link

Cannot install in PI4 #2

Closed Lorenzi70 closed 3 months ago

Lorenzi70 commented 4 years ago

Hi, being a user of the older solunar, I tried to install solunar2 on a Raspberry PI4 but when I try to compile (sudo make) I get the following error: src/numberformat.c: In function ‘numberformat_space_64’: src/numberformat.c:195:21: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ {aka ‘long long int’} [-Werror=format=] sprintf (in, "%ld", n); ~~^ ~ %lld

So cannot test the new one. Pity as the Json output would simplify a lot my current parsing. Regards Marco

kevinboone commented 4 years ago

Hi. Try removing the "-Werror" entry in the Makefile. By default all warnings are treated as fatal, and this one shouldn't be. None of the numbers used in Solunar are large enough to need a 64-bit integer, but I'm using a general-purpose routine that works on numbers that might be this large. I'll try to fix this properly when I get chance -- I'm away from my computer right now. Sorry about that.

On 7/30/20 9:46 AM, Lorenzi70 wrote:

Hi, being a user of the older solunar, I tried to install solunar2 on a Raspberry PI4 but when I try to compile (sudo make) I get the following error: src/numberformat.c: In function ‘numberformat_space_64’: src/numberformat.c:195:21: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ {aka ‘long long int’} [-Werror=format=] sprintf (in, "%ld", n); ~~^ ~ %lld

So cannot test the new one. Pity as the Json output would simplify a lot my current parsing. Regards Marco

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kevinboone/solunar2/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPPKXQX4T77YQB64VEW4GTR6EXPVANCNFSM4PNG6Y5Q.

Lorenzi70 commented 4 years ago

Thanks for the fast reply! Entry removed but get the same error Regards Marco

kevinboone commented 4 years ago

Hi. You'll still get the error message, but the program should build and run if -Werror is removed. If not, please post the complete output when running make.

On 7/30/20 10:53 AM, Lorenzi70 wrote:

Thanks for the fast reply! Entry removed but get the same error Regards Marco

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kevinboone/solunar2/issues/2#issuecomment-666269040, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPPKXRY2VHVMMF6WCZSEFLR6E7JRANCNFSM4PNG6Y5Q.

Lorenzi70 commented 4 years ago

It works. had to change makefile in "/home/pi/solunar2/klib" and not the one in the root. In fact there are three makefile, last one in "libsolunar", which is a bit confusing. Thanks, I can test it now Regards Marco

kevinboone commented 3 months ago

Closing because I removed -Werror.