search

kevinbungeneers / nhc-homekit

Niko Home Control HomeKit bridge
MIT License
22 stars 3 forks source link

Update AccessoryFactory.js #7

Closed nS-Gecko closed 4 years ago

nS-Gecko commented 4 years ago

Serial Number must be unique in order to be usable in Home Assistant

kevinbungeneers commented 4 years ago

Makes sense! Thanks!

nS-Gecko commented 4 years ago

Not that obvious because it was working with the apple Home app with unique id’s.

I took some time today to modify your package and handle dimmers and sockets which is working fine. But I’m really not used to GitHub to upload it and I don’t know if that could interest you since you mentioned you don’t have NHC anymore. I also had to modify you module nhc-client manually.

The code is not that clean but hey at least I learned to code something useful for npm ! I can send it to you if you want.

Regards, Guillaume.

Le 13 août 2020 à 19:28, Kevin Bungeneers notifications@github.com a écrit :

Makes sense! Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinbungeneers/nhc-homekit/pull/7#issuecomment-673607876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4PBE57XZYKTXSASXUJPITSAQPDXANCNFSM4P4RWBNA.

kevinbungeneers commented 4 years ago

Hey Guillaume,

Feel free to send me a pull request! There are probably other people out there who might find the support for dimmers and sockets quite useful.