search

kevinburke / customize-twitter-1.1

Add your own custom CSS to modify the Twitter Embeddable Widget
MIT License
92 stars 29 forks source link

Not working in IE #3

Closed danskker closed 11 years ago

danskker commented 11 years ago

returns to default css in IE

kevinburke commented 11 years ago

gah, i suspected it wouldn't. i need a way to select/traverse iframes in IE, it looks like they don't support the frames variable.

danskker commented 11 years ago

shame - it would be so cool f i didn't have to add my css directly into the twitter widget.js. Could it be something to do with the timing? I was using your plug in to disable the scrollbars and noticed in FF the plugin would sometimes not fire in the correct order and load the widget with the unmodified css.

kevinburke commented 11 years ago

Yes - I'm gonna check tonight, iframe injection's new to me, but there is probably still a race condition between the iframe being loaded, ready, and the content being injected. I'm going to check on some of the answers here and see if I can rearchitect things a little bit.

http://stackoverflow.com/questions/1654017/how-to-expose-iframes-dom-using-jquery

Kevin Burke | 415-723-4116 | www.twilio.com

On Tue, Apr 16, 2013 at 2:18 PM, danskker notifications@github.com wrote:

shame - it would be so cool f i didn't have to add my css directly into the twitter widget.js. Could it be something to do with the timing? I was using your plug in to disable the scrollbars and noticed in FF the plugin would sometimes not fire in the correct order and load the widget with the unmodified css.

— Reply to this email directly or view it on GitHubhttps://github.com/kevinburke/customize-twitter-1.1/issues/3#issuecomment-16472425 .

kevinburke commented 11 years ago

Hm, I just tried a test (my website, kev.inburke.com) in IE 10 and it worked okay. Which version of IE are you using?

danskker commented 11 years ago

IE7-9, we've not been given 10 yet..

Yes very strange - it was your demo page and my test page that failed before but the demo works good now. Must have been something local to my browser - apologies for the alarm..