search

kevinburke / doony

UI Improvements for Jenkins
http://doony.org
Other
970 stars 116 forks source link

Style issues with Phing plugin #11

Closed ghost closed 10 years ago

ghost commented 10 years ago

It appears there are some style issues with the phing plugin. In the attached image, four manually-drawn circles highlight two issues (some other info was whited-out for privacy):

1) Build target name for each step seems to use black text (circled three times).
2) 'BUILD FINISHED' message uses dark blue text and is hard to read (circled one time).

This might also be an issue with other plugins, but I have not checked.

image

kevinburke commented 10 years ago

Thanks for the report. Can you run "Inspect Element" on the elements you circled so I can add styles for it? Looks like you've already got the inspector window open so hopefully shouldn't be too bad :)

ghost commented 10 years ago

NP. There are probably more elements generated by phing than these two. Just a humble idea: maybe a catch-all to cover bases would work (to prevent clashing foreground/background colors, generally), assuming the console output DOM elements can be isolated via CSS.

image

kevinburke commented 10 years ago

I cloned the plugin and it looks like those were the only two that had issues. Fixed by 007d7a9

ghost commented 10 years ago

Just curious if you tested this, there is what appears to be some style sheet related to phing called perhaps in JS (still looking) that overrides the added styles using class selectors in doony.css.

ghost commented 10 years ago

image

ghost commented 10 years ago

Quick fix is to increase specificity, e.g. use span.phing-target. Not particularly stable but likely sufficient for the time being.

kevinburke commented 10 years ago

Sorry, I didn't test it, I just copied the query strings... you are right it's a specificity problem. Hopefully soon we'll get a #jenkins ID on the root element that we can use, until then I've been using .yui-skin-sam. I'll update it in a few minutes.