search

kevinburke / doony

UI Improvements for Jenkins
http://doony.org
Other
970 stars 116 forks source link

don't use rawgithub #17

Closed michaelkirk closed 10 years ago

michaelkirk commented 10 years ago

Your instructions recommend linking to assets hosted on http://rawgithub.com/ (I love rawgithub)

That's probably fine for 99% of deployments since they are low traffic, but wanted to make sure you were aware that rawgithub is not intended for long term hosting, and will start returning mischievous things if your site makes too many requests.

Maybe a disclaimer link to http://rawgithub.com/ is in order.

kevinburke commented 10 years ago

I note in the readme that you can use these "in development" and then say afterwards "You shouldn't use these in production", maybe I can be more clear?

michaelkirk commented 10 years ago

You're right. It's pretty clear. I missed it. :sheep: Sorry.

I made a PR to link to their disclaimer if you're interested. Thanks for the plugin! I'm excited to see progress on this.