search

kevinburke / doony

UI Improvements for Jenkins
http://doony.org
Other
970 stars 116 forks source link

IP address gets truncated in header #62

Closed sschuberth closed 10 years ago

sschuberth commented 10 years ago

For host without a name but only an IP address, the IP address gets truncated in the header. For example, if the IP address was 10.223.42.201, only "10.223" is show in the header.

kevinburke commented 10 years ago

Ah, yeah. The idea here was to only show subdomains, a lot of people were running instances at jenkins.mycompany.org, so the idea was "jenkins" would show up in the title.

The logic can probably be updated to match IP addresses.

Kevin Burke phone: 925.271.7005 | kev.inburke.com

On Mon, May 26, 2014 at 6:15 PM, Sebastian Schuberth < notifications@github.com> wrote:

For host without a name but only an IP address, the IP address gets truncated in the header. For example, if the IP address was 10.223.42.201, only "10.223" is show in the header.

— Reply to this email directly or view it on GitHubhttps://github.com/kevinburke/doony/issues/62 .

sschuberth commented 10 years ago

If you can point me at the code location to change, I can give it a try.

kevinburke commented 10 years ago

Right here: https://github.com/kevinburke/doony/blob/master/src/theme.js#L12

I'll minify etc the changes if you can just make them in the theme.js file.

sschuberth commented 10 years ago

Actually, there's another occurrence at https://github.com/kevinburke/doony/blob/master/doony.js#L339. I've changes both in my pull request: https://github.com/kevinburke/doony/pull/65