search

kevinburke / doony

UI Improvements for Jenkins
http://doony.org
Other
970 stars 116 forks source link

Theme makes 1.572 look a bit wonky #70

Closed chr0n1x closed 10 years ago

chr0n1x commented 10 years ago

Just try it out! I can't really describe what's going on :P

kevinburke commented 10 years ago

thanks for the report! this is likely because some styles are being merged into the core project. will take a look soon.

On Tuesday, July 15, 2014, Kevin Ran notifications@github.com wrote:

Just try it out! I can't really describe what's going on :P

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/issues/70.

Kevin Burke phone: 925.271.7005 | kev.inburke.com

ghost commented 10 years ago

Good to hear you will look into this! I love this theme, can't stand that old black theme they've added into it now. No themes I've tried seem to override it. Take a look if you'd like: http://ci.majornoob.com/

chr0n1x commented 10 years ago

@JakeA thanks for providing a live example!

ghost commented 10 years ago

Sure! I'll leave it on for a while unless it begins to impede my development (I'm sure it won't.)

talios commented 10 years ago

The majornoob.com instance looks good to me, unlike my own server ( https://www.evernote.com/shard/s20/sh/5022c84f-853f-436f-bbfc-65303d4c2e59/c9a6e4155d9a6903435b4adb87bc02f5 ) which seems to drop the job table beneath everything using 1.572 and HEAD@master.

chr0n1x commented 10 years ago

@talios Im seeing that too.

kevinburke commented 10 years ago

Mark, this may have to do with the size of your viewport. The job view does the same for me around ~900 px wide.

Kevin Burke phone: 925.271.7005 | kev.inburke.com

On Tue, Jul 15, 2014 at 7:15 PM, Mark Derricutt notifications@github.com wrote:

The majornoob.com instance looks good to me, unlike my own server ( https://www.evernote.com/shard/s20/sh/5022c84f-853f-436f-bbfc-65303d4c2e59/c9a6e4155d9a6903435b4adb87bc02f5 ) which seems to drop the job table beneath everything using 1.572 and HEAD@master.

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/issues/70#issuecomment-49116266.

talios commented 10 years ago

True - taking a look I see:

@media (min-width: 992px)
.col-md-3 {
  width: 25%;
}

coming from /static/12b20ee4/css/responsive-grid.css, disabling that width works when I zoom out. The font size of the side panel text is horribly HUGE ( 1.3em ) - lowering that also doesn't help unless I remove the 25% and zoom out. I wish I knew more CSS foo :)

kevinburke commented 10 years ago

yup - there's a fix for this soon, I think.

On Tuesday, July 15, 2014, Mark Derricutt notifications@github.com wrote:

True - taking a look I see:

@media (min-width: 992px) .col-md-3 { width: 25%; }

coming from /static/12b20ee4/css/responsive-grid.css, disabling that width works when I zoom out. The font size of the side panel text is horribly HUGE ( 1.3em ) - lowering that also doesn't help unless I remove the 25% and zoom out. I wish I knew more CSS foo :)

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/issues/70#issuecomment-49119535.

Kevin Burke phone: 925.271.7005 | kev.inburke.com

leafduo commented 10 years ago

Same problem here

ghost commented 10 years ago

Oh sorry guys, I totally forgot I edited the WAR's css file. Lol - It seems like you know the problem, but I can revert it if you need me to.

kevinburke commented 10 years ago

Okay, the latest master (no version number yet) should have a fix for the sidebar text size issue. can you let me know the results?

leafduo commented 10 years ago

@kevinburke I tested latest master, and still have this issue.

talios commented 10 years ago

@kevinburke still seeing the issue here as well

ghost commented 10 years ago

I reverted my Jenkins to the old CSS file, so it would look weird with the CDN Jenkins. I'm currently linking directly to the GitHub Jenkins and it appears the sidebar text-size is indeed fixed.

SleepyAkubi commented 10 years ago

Getting the same issues at http://builds.thewarpdimension.com/

kevinburke commented 10 years ago

Thanks everyone for the feedback. The core project switched to a div-based layout a week ago or so and I was adding some padding that pushed the main content below the sidebar.

I've pushed a change that should address this problem. Can you download the latest version of doony and try it out? Will be tagged as 2.0.

talios commented 10 years ago

Bless you Sir Kevin! You are indeed a knight of the x-rounded-css <table/> :)

Looks awesome again.

ghost commented 10 years ago

Will test as soon as I finish my server transfer, will report back :)

ghost commented 10 years ago

Hmm, I see no change when I apply the theme.

ghost commented 10 years ago

Here is what I see with both the master's applied: http://ci.majornoob.com/

kevinburke commented 10 years ago

Hi Jake, Can you provide me with a login for that site? My email is kev@inburke.com.

Kevin Burke phone: 925.271.7005 | kev.inburke.com

On Mon, Jul 21, 2014 at 7:01 PM, Jake Andersen notifications@github.com wrote:

Here is what I see with both the master's applied: http://ci.majornoob.com/

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/issues/70#issuecomment-49689712.

kevinburke commented 10 years ago

I'm also not sure you are running the latest jenkins master, because Verdana is still appearing as the default font on majornoob, but it should be Helvetica.

Kevin Burke phone: 925.271.7005 | kev.inburke.com

On Mon, Jul 21, 2014 at 7:29 PM, Kevin Burke kev@inburke.com wrote:

Hi Jake, Can you provide me with a login for that site? My email is kev@inburke.com .

Kevin Burke phone: 925.271.7005 | kev.inburke.com

On Mon, Jul 21, 2014 at 7:01 PM, Jake Andersen notifications@github.com wrote:

Here is what I see with both the master's applied: http://ci.majornoob.com/

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/issues/70#issuecomment-49689712.

leafduo commented 10 years ago

I've tested the latest master, it works nice on Jenkins 1.573!

SleepyAkubi commented 10 years ago

Fixed! Can confirm.

aried3r commented 10 years ago

Thanks for your work!

@kevinburke, I know we've already passed that (since you're going to release 2.0), but wouldn't it be easier to have doony have the same version number as the Jenkins version it supports?

chr0n1x commented 10 years ago

@kevinburke looks fixed to me! Thank you!

kevinburke commented 10 years ago

@aried3r that would be a good idea, but also raises questions about whether doony theme supports a version number before/after the one it's tacked to, and I don't want to release a new doony version every Monday. :(

aried3r commented 10 years ago

True, would be nice if we could test this automatically somehow. I'm not sure how to tackle this, maybe CSS coverage? I guess, after all, we'll just notice when things look broken.

ghost commented 10 years ago

Oops, didn't see that until now. One mo'