search

kevinburke / doony

UI Improvements for Jenkins
http://doony.org
Other
970 stars 116 forks source link

Doony "build now" button misbehaving (wrong permission?) #73

Open ghost opened 10 years ago

ghost commented 10 years ago

As seen here: https://www.dropbox.com/s/wdo1b8zb6n2y02r/jenkins-doony-no_build_permission.PNG

This occurs while using the Role-based Strategy Plugin (I use this to manage permissions on my Jenkins instance.)

It suggests that I might need the build permission, but I have that permission already as seen here: https://www.dropbox.com/s/h81pjgc40g38h6q/jenkins-doony-build_permission_present.PNG

I'm not completely sure if this is a doony problem, but it makes sense since doony is the one adding the extra "build now" buttons.

Thanks!

kevinburke commented 10 years ago

It's possible. Can you check for errors in your console and paste any relevant messages here?

Kevin Burke phone: 925.271.7005 | kev.inburke.com

On Wed, Jul 23, 2014 at 4:21 PM, Jake Andersen notifications@github.com wrote:

As seen here: https://www.dropbox.com/s/wdo1b8zb6n2y02r/jenkins-doony-no_build_permission.PNG

This occurs while using the Role-based Strategy Plugin (I use this to manage permissions on my Jenkins instance.)

It suggests that I might need the build permission, but I have that permission already as seen here: https://www.dropbox.com/s/wdo1b8zb6n2y02r/jenkins-doony-no_build_permission.PNG

I'm not completely sure if this is a doony problem, but it makes sense since doony is the one adding the extra "build now" buttons.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/issues/73.

ghost commented 10 years ago

Here is what pops up when I click "Build Now"

Jul 23, 2014 10:57:38 PM hudson.security.csrf.CrumbFilter doFilter WARNING: No valid crumb was included in request for /job/LogCommands/build. Returning 403.

Now, the "No valid crumb ..." message was resolved (or so I thought) when I changed the Jenkins crumb from .crumb to JCrumb. I had to do this because NGINX sees the default .crumb as an error as ignores it. I'm not sure why it would think it was invalid now, as this is the only part of Jenkins now seeing this as invalid.

kevinburke commented 10 years ago

Gah, it's possible the server is now checking CSRF.

Can you provide some more details? I assume you need to be logged in to do builds on your machine?

kevinburke commented 10 years ago

can you check whether it still fails in the same way without the strategy plugin? i think it might have to do with logged-in users.

ghost commented 10 years ago

Sure, one sec.

ghost commented 10 years ago

I set it to "Anyone can do anything" and the problem persisted. Yes, to do builds you need to be logged in on my machine.

tolidano commented 6 years ago

This is now happening for me as well.

<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 403 No valid crumb was included in the request</title>
</head>
<body><h2>HTTP ERROR 403</h2>
<p>Problem accessing /job/deploy-production-all-deals/build. Reason:
<pre>    No valid crumb was included in the request</pre></p><hr><a href="http://eclipse.org/jetty">Powered by Jetty:// 9.4.z-SNAPSHOT</a><hr/>

</body>
</html>
tolidano commented 6 years ago

Ah - and we have found the issue. It's because the job has parameters. And by hitting Build Now, none are passed.

You should make it smart enough to see if there are parameters and have that link go to the "Build With Parameters" page if there are any (or let me pick, or something).