search

kevinburke / gobike

https://bikeshare.science
6 stars 0 forks source link

Generate a static Github page site #10

Closed kyleconroy closed 6 years ago

kyleconroy commented 6 years ago

To generate the site, just run make site serve. Iteration speed is still slow as it has to reparse the trips every time, but this is something we can easily fix by splitting the trip data JS into a separate build step.

kevinburke commented 6 years ago

Can we add a Travis CI config that running "make stats" does not generate a Git diff?

you can use github.com/kevinburke/differ for this. I use it in the Travis CI config for github.com/kevinburke/go-bindata

kevinburke commented 6 years ago

Also can we still wrap the http.FileServer in a handlers.Log? It's nice to see what requests are coming in when you run locally.

kyleconroy commented 6 years ago

I sadly can't use differ right now, because generating the site requires all the data to be downloaded into the /data directory. I can write another PR that loads all the official data before we run tests, which should also catch future breakages.

kevinburke commented 6 years ago

Oh, right, that's right.

kyleconroy commented 6 years ago

Okay, I think it's ready

kevinburke commented 6 years ago

Alright I'm heading to bed so go for it