BlueZDBus: Unexport app and advertisement on stop()

kevincar / bless

Cross-platform Bluetooth Low Energy Server Python Library

MIT License

78 stars 26 forks source link

BlueZDBus: Unexport app and advertisement on stop() #122

Closed Mimoja closed 5 months ago

Mimoja commented 7 months ago

Currently neither application nor advertisement are unregistered on server stop. This leads to an re-export in case of a later start() which dbus-fast will acknoledge with an exception:

ValueError: An interface with this name is already exported on this bus at path "/": "org.bluez"

Instead of only exporting once and keeping track internally we instead unexport the interfaces on server shutdown.

Mimoja commented 5 months ago

Would you like me to rebase?

kevincar commented 5 months ago

Hi @Mimoja , sorry for the delay on this, and thank you so much for providing these changes! Yes, If you could rebase to current develop branch that will help facilitate development.

Mimoja commented 5 months ago

No problem. I opened #125 as I couldn't change my source branch and wanted to keep the naming. Thank you for taking the time to take a look :)