Open GoogleCodeExporter opened 8 years ago
Original comment by pphaneuf
on 18 Mar 2008 at 6:28
Thumbs down on the queue and daily job. It would be simpler and more efficient
to
simply verify demo files as they are posted to qserv.pl (in do_postdemo).
There's a -verify <demofile> commandline option that plays a demo recording
very
fast. Combined with -novideo, it could be used as a basis to implement this
feature
request. What's missing is a mechanism for reporting the result of the
verification
to a calling script so that the whole thing can be automated.
Option 1: grab the packet that contains the game result at the end of the
recording
and compare to the actual result from playing it back. Return a status code
from
main. In qserv.pl, extract that same packet (using RecReader.pm) and use the
info to
rank the recording (instead of the unverified information provided by the
client in
$params).
Option 2: print the game result to stdout and compare that to the information
provided by the client ($params). Reject any demo that doesn't match.
The first option is a little bit more work but feels a bit cleaner.
Original comment by slaj...@gmail.com
on 18 Mar 2008 at 8:25
Original comment by slaj...@gmail.com
on 18 Mar 2008 at 9:33
Started work on this.
Original comment by slaj...@gmail.com
on 19 Mar 2008 at 12:42
I added a comment from RZ***Brandon on issue #7 which might have to do with
this.
Original comment by pphaneuf
on 19 Mar 2008 at 2:13
Original comment by slaj...@gmail.com
on 19 Mar 2008 at 4:35
Original issue reported on code.google.com by
pphaneuf
on 18 Mar 2008 at 6:20