kevinchappell / formBuilder

A jQuery plugin for drag and drop form creation
https://formbuilder.online
MIT License
2.6k stars 1.38k forks source link

Form render error with custom controls #1581

Closed mtthwprtchrd closed 1 month ago

mtthwprtchrd commented 1 month ago

Description:

We have a number of simple custom controls that we have written than were working as of version 3.9.9. We have just upgraded to the latest version of formbuilder 3.19.12. For example after rendering the signing on our signature pad control (based on https://github.com/szimek/signature_pad ) no longer works but it does work in design mode. We see this error in the inspector image

Environment Details:

Expected Behavior

Able to sign in the signature area

Actual Behavior

Not able to draw in the signature area

Steps to Reproduce

Host and load the attached repro files. Drag a signature onto the form Click the Render button Try to sign in the signature panel Open the inspector and view the console. You can see the above error

Screenshot - (optional)

Minimal repro sample

Remove .txt from zip file repro.zip.txt

kevinchappell commented 1 month ago

thank you for reporting this. I'm looking into it now

kevinchappell commented 1 month ago

There was a syntax error in your custom control. Try this updated version: sigPad.zip

mtthwprtchrd commented 1 month ago

Hi @kevinchappell This fixed the issue. Thank you very much for resolving this for us. Apologies for wasting your time.

kevinchappell commented 1 month ago

@mtthwprtchrd no worries, it was good experience for me