search

kevinclement / SimpleArmory

World of Warcraft armory site that presents your armory in a simple manor.
http://simplearmory.com
MIT License
87 stars 71 forks source link

Support Link Previews via Open Graph #576

Open kevinclement opened 11 months ago

kevinclement commented 11 months ago

When people add links to site in discord, discord will try to render a nice preview. For SA that isn't available so its just a lame login image.

image

I believe if we add open graph support to the page it should make this nicer. See https://ogp.me/.

maxdekrieger commented 11 months ago

Love this, I had no idea how this preview could be changed. Will it a problem that ~most~ all of the logic and rendering is happening client-side?

d-ellis commented 9 months ago

Love this, I had no idea how this preview could be changed. Will it a problem that ~most~ all of the logic and rendering is happening client-side?

Shouldn't be a problem at all. I've got static webpages that are served just with HTML using GitHub Pages, and Open Graph works for them

Edit: actually it depends on what information you want in the cards. Basic information is fine, but dynamic information I think would need to be generated on a server. The information is pulled from the HTML, scripts aren't executed so the info can't be generated from scripts afaik