kevinclement / SimpleArmory

World of Warcraft armory site that presents your armory in a simple manor.
http://simplearmory.com
MIT License
86 stars 71 forks source link

Toss a Seed to Your Hunter... isn't in my journal #640

Closed ptarjan closed 1 month ago

ptarjan commented 1 month ago

I do see the achievement here: https://www.wowhead.com/achievement=14791/toss-a-seed-to-your-hunter and the comments do say "All covenants allowed." but in-game I see 73/73 achievements but on my simple armory profile it shows 73/74 https://simplearmory.com/#/us/proudmoore/hadryan/achievements/exploration. Should this be removed? image

SolestialDev commented 1 month ago

Hi, this is a hidden achievement ingame and it does not show up in your achievement journal until you have obtained it.

There's a few other achievements like this as well from SL, such as; In the Hot Seat To the Moon

Hope this answers your question.

ptarjan commented 1 month ago

Ah interesting. Should we hide it too then? Similar to how we do feats of strength. And then maybe a show all option somewhere to unhide everything.

On Mon, Sep 16, 2024 at 12:56 AM Sol @.***> wrote:

Hi, this is a hidden achievement ingame and it does not show up in your achievement journal until you have obtained it.

There's a few other achievements like this as well from SL, such as; In the Hot Seat https://www.wowhead.com/achievement=14733/in-the-hot-seat To the Moon https://www.wowhead.com/achievement=14887/to-the-moon

Hope this answers your question.

— Reply to this email directly, view it on GitHub https://github.com/kevinclement/SimpleArmory/issues/640#issuecomment-2352238212, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJZT7WADI4KXCXS3AKPXTZW2FKZAVCNFSM6AAAAABOIPEULCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSGIZTQMRRGI . You are receiving this because you authored the thread.Message ID: @.***>

SolestialDev commented 1 month ago

Seems a bit unnecessary considering there's only 3 of those achievements in the game. But also simplearmory is meant to give a clear overview of everything you can obtain, so I think we should always be displaying it, people shouldn't need to search for it.

ptarjan commented 1 month ago

Oh ok! I didn’t realize that was a goal. If so, it’s fine to show them all. Having said that, is there any way to show all the feats of strength I could work towards?

On Mon, Sep 16, 2024 at 10:03 AM Sol @.***> wrote:

Seems a bit unnecessary considering there's only 3 of those achievements in the game. But also simplearmory is meant to give a clear overview of everything you can obtain, so I think we should always be displaying it, people shouldn't need to search for it.

— Reply to this email directly, view it on GitHub https://github.com/kevinclement/SimpleArmory/issues/640#issuecomment-2353456764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJZT4VF4T3OF3Z2Z7BO3LZW4FMRAVCNFSM6AAAAABOIPEULCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGQ2TMNZWGQ . You are receiving this because you authored the thread.Message ID: @.***>

SolestialDev commented 1 month ago

Oh ok! I didn’t realize that was a goal. If so, it’s fine to show them all. Having said that, is there any way to show all the feats of strength I could work towards?

Added this in now, it can now be found in the menu under Settings!

ptarjan commented 1 month ago

Thank you for this! And thanks of being so fast and receptive to feedback. You have a lovely site.

On Sun, Sep 22, 2024 at 8:49 PM Sol @.***> wrote:

Closed #640 https://github.com/kevinclement/SimpleArmory/issues/640 as completed.

— Reply to this email directly, view it on GitHub https://github.com/kevinclement/SimpleArmory/issues/640#event-14356888573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJZT7KCUCMQSOYQYD7GXLZX6FUHAVCNFSM6AAAAABOIPEULCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGM2TMOBYHA2TOMY . You are receiving this because you authored the thread.Message ID: @.***>