kevincobain2000 / gobrew

Go version manager, written in Go. Super simple tool to install and manage Go versions. Install go without root. Gobrew doesn't require shell rehash.
https://medium.com/web-developer/go-version-manager-gobrew-c8750157dfe6
MIT License
364 stars 24 forks source link

fixes #102 light background #103

Closed kevincobain2000 closed 1 year ago

kevincobain2000 commented 1 year ago

Fixes #102

codecov-commenter commented 1 year ago

Codecov Report

Merging #103 (1bd6da6) into master (d1918ff) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   50.59%   50.59%           
=======================================
  Files           1        1           
  Lines         508      508           
=======================================
  Hits          257      257           
  Misses        214      214           
  Partials       37       37           
juev commented 1 year ago

If we want to support windows, we should enable ANSI processing: https://github.com/muesli/termenv#platform-support

update: we dont use termenv for output, and we do not need this. sorry.

kevincobain2000 commented 1 year ago

yea I was worried about Windows :(

juev commented 1 year ago

We use termenv only for check. And we dont need to setup another output for windows. All fine.

Zerpet commented 1 year ago

I built the code in this PR, and the result looks good đź‘Ť Thank you!

Screenshot 2023-05-10 at 09 51 08
kevincobain2000 commented 1 year ago

We use termenv only for check. And we don't need to setup another output for windows.

I am sorry @juev I don't follow, can you please comment on the code for the check? Thanks

juev commented 1 year ago

@kevincobain2000 That’s my mistake. I did not take into account the fact that the library is used only to check the background type. In this case, there is no need to do anything to work correctly in windows.

Just check that the color is selected correctly, I wrote about it in the code.