search

kevincobain2000 / gobrew

Go version manager, written in Go. Super simple tool to install and manage Go versions. Install go without root. Gobrew doesn't require shell rehash.
https://medium.com/web-developer/go-version-manager-gobrew-c8750157dfe6
MIT License
364 stars 24 forks source link

Fixes #113 where version 1.21.0 was falling back to 1.21 #114

Closed kevincobain2000 closed 1 year ago

kevincobain2000 commented 1 year ago

Fixes #113

OK should have no impact

╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/semantic-comply›
╰─$ go run cmd/gobrew/main.go install 1.21rc3
==> [Info] Downloading version: 1.21rc3
==> [Info] Downloading from: https://go.dev/dl/go1.21rc3.darwin-arm64.tar.gz
==> [Info] Downloading to: /Users/pulkit.kathuria/.gobrew/downloads
Downloading   0% |

OK - should fail

╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/semantic-comply›
╰─$ go run cmd/gobrew/main.go install 1.21                                                                                                                                                                                                                                  1 ↵
==> [Info] Downloading version: 1.21
==> [Info] Downloading from: https://go.dev/dl/go1.21.darwin-arm64.tar.gz
==> [Info] Downloading to: /Users/pulkit.kathuria/.gobrew/downloads
==> [Info] Downloading version failed: https://go.dev/dl/go1.21.darwin-arm64.tar.gz returned status code 404
==> [Error]: Please check connectivity to url: https://go.dev/dl/go1.21.darwin-arm64.tar.gz
exit status 1

OK should pass

╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/semantic-comply›
╰─$                                                                                                                                                                                                                                                                         1 ↵
╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/semantic-comply›
╰─$ go run cmd/gobrew/main.go install 1.21.0                                                                                                                                                                                                                              130 ↵
==> [Info] Downloading version: 1.21.0
==> [Info] Downloading from: https://go.dev/dl/go1.21.0.darwin-arm64.tar.gz
==> [Info] Downloading to: /Users/pulkit.kathuria/.gobrew/downloads
Downloading   4% |████████                                                                                                                                                                                                                       | (2.8/62 MB, 10 MB/s) [0s:5s]^Csignal: interrupt

OK Keep ASIS passing https://github.com/kevincobain2000/gobrew/pull/24

╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/semantic-comply›
╰─$ go run cmd/gobrew/main.go install 1.17.0                                                                                                                                                                                                                                1 ↵
==> [Info] Downloading version: 1.17
==> [Info] Downloading from: https://go.dev/dl/go1.17.darwin-arm64.tar.gz
==> [Info] Downloading to: /Users/pulkit.kathuria/.gobrew/downloads
Downloading   0% |                                                                                                                                                                                                                            | (1.1/123 MB, 6.3 MB/s) [0s:19s]^Csignal: interrupt
╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/semantic-comply›
╰─$ go run cmd/gobrew/main.go install 1.17                                                                                                                                                                                                                                  1 ↵
==> [Info] Downloading version: 1.17
==> [Info] Downloading from: https://go.dev/dl/go1.17.darwin-arm64.tar.gz
==> [Info] Downloading to: /Users/pulkit.kathuria/.gobrew/downloads
Downloading   2% |████                                                                                                                                                                                                                        | (3.4/123 MB, 9.1 MB/s) [0s:13s]^Csignal: interrupt
╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/semantic-comply›
╰─$ go run cmd/gobrew/main.go ls-remote |tail -5                                                                                                                                                                                                                            1 ↵
    1.20rc1  1.20rc2  1.20rc3

1.21    1.21.0
    1.21rc1  1.21rc2  1.21rc3  1.21rc4
codecov-commenter commented 1 year ago

Codecov Report

Merging #114 (e617907) into master (f0c6945) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   50.59%   50.59%           
=======================================
  Files           1        1           
  Lines         508      508           
=======================================
  Hits          257      257           
  Misses        214      214           
  Partials       37       37