kevincobain2000 / gobrew

Go version manager, written in Go. Super simple tool to install and manage Go versions. Install go without root. Gobrew doesn't require shell rehash.
https://medium.com/web-developer/go-version-manager-gobrew-c8750157dfe6
MIT License
364 stars 24 forks source link

Change to gookit/color #122

Closed juev closed 12 months ago

juev commented 12 months ago

This PR was created for several changes:

  1. The library for displaying text with color has been changed. Profiles are used, eliminating the need to use third-party libraries to determine the background color. It’s better to check it again, of course, but it was displayed correctly for me.
  2. After migration, there was no longer a need to use custom functions for text output.
  3. In places where errors are checked, where it is necessary to interrupt program execution, the CheckError function is used.
  4. Added a check for the version in use, and if the version is less than 1.21, we check the version without zero for output. Otherwise with zero, intended to fix #118

For the future, I plan to move work with github into separate interfaces and rework the tests. But this will be in a separate PR.

github-actions[bot] commented 12 months ago

Summary CoverItUp: kevincobain2000/gobrew

Type master refactoring
coverage 59.1 % 59.2 % +
go-binary-size 5884 KB 5836 KB -
go-mod-dependencies 31 32 +
go-sec-issues 7 6 -
build-time 7 sec 6 sec -

Generated by Cover It Up. View full report https://coveritup.app/kevincobain2000/gobrew

badge badge badge badge badge

juev commented 12 months ago

As I see, there was an error in the tests:

=== RUN   TestUpgrade
Error: ror]: json: cannot unmarshal object into Go value of type []gobrew.Tag
FAIL    github.com/kevincobain2000/gobrew   49.152s

I'll try to fix it today.

kevincobain2000 commented 12 months ago

Thanks @juev I ll check why the charts are not rendering on https://coveritup.app/kevincobain2000/gobrew Sorry, that's a codecov thing that I added, it was still in beta.

github-actions[bot] commented 12 months ago

Summary CoverItUp: kevincobain2000/gobrew

Type master refactoring
coverage 59.1 % 59.2 % +
go-binary-size 5884 KB 5836 KB -
go-mod-dependencies 31 32 +
go-sec-issues 7 6 -
build-time 7 sec 7 sec

Generated by Cover It Up. View full report https://coveritup.app/kevincobain2000/gobrew

badge badge badge badge badge