search

kevincobain2000 / gobrew

Go version manager, written in Go. Super simple tool to install and manage Go versions. Install go without root. Gobrew doesn't require shell rehash.
https://medium.com/web-developer/go-version-manager-gobrew-c8750157dfe6
MIT License
374 stars 26 forks source link

check windows #93

Closed kevincobain2000 closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #93 (87dcdee) into master (3d7561d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   51.13%   51.13%           
=======================================
  Files           1        1           
  Lines         483      483           
=======================================
  Hits          247      247           
  Misses        209      209           
  Partials       27       27

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

juev commented 1 year ago

As it seems to me, these lines: https://github.com/kevincobain2000/action-gobrew/blob/master/action.yml#L17-L19

do not worked on windows. What do you think?

kevincobain2000 commented 1 year ago

Yea, I have tbh no idea about windows.

beppler commented 1 year ago

Interesting, I have the same change you made on a branch here and it worked:

https://github.com/beppler/gobrew/actions/runs/3939062367

kevincobain2000 commented 1 year ago

probably failing at gobrew version on windows.

kevincobain2000 commented 1 year ago

Oddly enough, gobrew version consumes lot of time on Mac

╰─$ time gobrew version
[INFO] gobrew version is 1.7.9
gobrew version  0.01s user 0.01s system 0% cpu 6.308 total
kevincobain2000 commented 1 year ago

ah because gobrew version calls github api to get the latest version and can also lead to api rate limit exceeded, making it fail

kevincobain2000 commented 1 year ago

Raised issue here #94

kevincobain2000 commented 1 year ago

This pull req is ready for review and merge

kevincobain2000 commented 1 year ago

Interesting, I have the same change you made on a branch here and it worked: https://github.com/beppler/gobrew/actions/runs/3939062367

After finding the reason: my workflow had gobrew version which failed due to rate limit exceeded as it calls api.github.., therefore your workflow passed with no worries.

juev commented 1 year ago

Very intresting