kevincobain2000 / gobrew

Go version manager, written in Go. Super simple tool to install and manage Go versions. Install go without root. Gobrew doesn't require shell rehash.
https://medium.com/web-developer/go-version-manager-gobrew-c8750157dfe6
MIT License
364 stars 24 forks source link

Fix upgrade on windows and tests #96

Closed beppler closed 1 year ago

beppler commented 1 year ago

On Windows the executable can not be removed while it is running, but we can rename it and then finish the upgrade.

Also added a new version of the constructor named NewGoBrewDirectory.

With this new constructor all tests related to version management and upgrade can run in isolated directories.

beppler commented 1 year ago

The failure on macos-latest is due to a rate limit on the api used on version check.

codecov-commenter commented 1 year ago

Codecov Report

Merging #96 (b3ed825) into master (656790f) will increase coverage by 0.17%. The diff coverage is 37.50%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   51.56%   51.73%   +0.17%     
==========================================
  Files           1        1              
  Lines         479      489      +10     
==========================================
+ Hits          247      253       +6     
+ Misses        205      198       -7     
- Partials       27       38      +11     
Impacted Files Coverage Δ
gobrew.go 51.73% <37.50%> (+0.17%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.