kevincobain2000 / laravel-erd

Automatically generate ERD Diagrams from Model's relations in Laravel
https://medium.com/web-developer/laravel-automatically-generate-interactive-erd-from-eloquent-relations-83fe65440716
138 stars 25 forks source link

Fix routes registering. #16

Closed dfsmania closed 2 years ago

dfsmania commented 2 years ago

Currently, routes registering is not working nicely since config('laravel-erd.url') is not readed correctly on service provider:

<?php

namespace Kevincobain2000\LaravelERD;

use Spatie\LaravelPackageTools\Package;
use Spatie\LaravelPackageTools\PackageServiceProvider;
use Kevincobain2000\LaravelERD\Commands\LaravelERDCommand;
use Route;

class LaravelERDServiceProvider extends PackageServiceProvider
{
    public function configurePackage(Package $package): void
    {
        $package
            ->name('laravel-erd')
            ->hasConfigFile('laravel-erd')
            ->hasViews()
            ->hasCommand(LaravelERDCommand::class);

        // TRY TO LOG VALUE OF config('laravel-erd.url') HERE, IT WILL BE NULL.

        Route::get(config('laravel-erd.url'), [\Kevincobain2000\LaravelERD\Controllers\LaravelERDController::class, 'index'])
            ->name('laravel-erd.index')
            ->middleware(config('laravel-erd.middlewares'));
    }
}

This PR introduces routes configuration as documented by spatie/laravel-package-tools to fix route registering.

kevincobain2000 commented 2 years ago

Thanks. I will merge this today.