search

kevincox / youtube-e2l

A Firefox addon to replace YouTube embeds with links to the video.
https://addons.mozilla.org/en-US/firefox/addon/youtube-embed2link/
Apache License 2.0
4 stars 3 forks source link

Doesn't work with Firefox 34 on Android #10

Closed kparal closed 9 years ago

kparal commented 9 years ago

Hello, thanks for a great extension. It works correctly for me with Firefox 33 (stable) on Android. But it doesn't work with Firefox 34 (Beta) on Android. A regular YouTube object is shown, the extension doesn't seem to have any effect.

Can you please fix it? Thanks!

kevincox commented 9 years ago

Thanks for letting me know. I'll look into it when I get a chance.

kparal commented 9 years ago

Firefox 34 is now stable, still broken. The same in Beta (Firefox 35).

kevincox commented 9 years ago

I know, and I'm sorry. This is still siting in my inbox but I have had no time to work on it. If you are a developer a patch would be very welcome, but otherwise I think I should have some time in the next week or two.

AlexVallat commented 9 years ago

I've attached a debugger, and it's throwing a "Component does not have requested interface" error. Some further investigation leads me to believe that this is almost certainly due to https://bugzilla.mozilla.org/show_bug.cgi?id=1107240 but I have no idea when or if that will get fixed.

According to one of the comments on the issue, it can be worked around by not using a contentStyleFile, which is not exactly a solution. I don't know if it's worth doing anything to try and fix this here, or if the best idea is to wait and see if Mozilla fix it on their end.

kevincox commented 9 years ago

This should be fixed by the pull request above. It implements a workaround until firefox gets fixed.

kparal commented 9 years ago

Thank you. I'll be waiting for a new version on addons.mozilla.org.