issue 10 workaround (Bug 1107240 - Exception 'Component does not have req...

kevincox / youtube-e2l

A Firefox addon to replace YouTube embeds with links to the video.

https://addons.mozilla.org/en-US/firefox/addon/youtube-embed2link/

Apache License 2.0

4 stars 3 forks source link

issue 10 workaround (Bug 1107240 - Exception 'Component does not have req... #11

Closed prrt714 closed 9 years ago

prrt714 commented 9 years ago

workaround for Bug 1107240 - Exception "Component does not have requested interface" (mobile)

Doesn't work with Firefox 34 on Android #10

kevincox commented 9 years ago

It's ugly but it looks like it will work. I haven't got the chance to test is yet but could you just add surrounding comments to make it clear it is a workaround. Also keep the classname, it doesn't hurt to have and some people could have custom styling. Then I'll test and merge it when I get a chance, hopefully this week.

tn.className = "embed2yt-thumbnail";
// Start for workaround for https://bugzil.la/1107240
... set styles...
// End of workaround.

That way I can easily see what I need to remove once the fix is released.

prrt714 commented 9 years ago

I have just added the comments and uncommented the lines with className. I tested this fix with mobile FF 36.0.1, mobile firefox_aurora 38a2, desktop FF 36.0.

kevincox commented 9 years ago

Ok, thanks so much for the patch, I just want to do a quick test then I will merge it.

kevincox commented 9 years ago

Thanks again for the workaround. I've uploaded version 1.9.6 to AMO for review. It should be available soon.