Seems not work with Firefox Mobile 28 (Aurora)

[AlexVallat]

It worked fine with 27.0a2, but when Firefox Mobile updated itself to 28.0a2 it's not working any more. I can't see any obvious reasons why not, and it still seems to be working fine on the Desktop browser.

For the moment, I'll downgrade back to 27, but it would be really nice if this could be fixed for 28. Or is it a bug with Firefox or Jetpack?

[kevincox]

It appears that they changed the require() paths for the addon-sdk. I have uploaded an updated version. I would appreciate if you could try it out and let me know.

https://addons.mozilla.org/en-US/firefox/addon/youtube-embed2link/versions/1.9.4

[AlexVallat]

Thanks for looking into this so quickly. Unfortunatly it doesn't seem to have helped: I installed 1.9.4 and re upgraded to aurora 28 and the youtube videos are back to being (html5 iframe) embeds. Is there anything else I can do to help track this down?

[kevincox]

Sorry for the delay.

I can confirm that it doesn't work on ff Android 28 but it does work with 27.

I should have time to fix this issue today or tomorrow.

[AlexVallat]

No problem, thanks for getting back to me. I'm sure it's something unhelpful Firefox has changed, but if you can figure out a workaround it would be nice to unblock it from updating itself again.

[kevincox]

This appears to be an Addon-SDK bug. The following error shows up in the logs multiple times.

I/Gecko   ( 5480): console.error: youtube-embed2link:
E/GeckoConsole( 5480): [JavaScript Error: "(new TypeError("viewFor is undefined", "resource://gre/modules/XPIProvider.jsm -> jar:file:///mnt/sdcard/jetpack-profile/extensions/youtube-e2l@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/tab-fennec.js", 182))"]
I/Gecko   ( 5480):   Message: TypeError: viewFor is undefined
I/Gecko   ( 5480):   Stack:
I/Gecko   ( 5480):     @resource://gre/modules/commonjs/sdk/tabs/tab-fennec.js:182
I/Gecko   ( 5480): CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129
I/Gecko   ( 5480): @resource://gre/modules/commonjs/sdk/tabs/tab.js:15
I/Gecko   ( 5480): CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129
I/Gecko   ( 5480): @resource://gre/modules/commonjs/sdk/tabs/helpers.js:15
I/Gecko   ( 5480): CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129
I/Gecko   ( 5480): @resource://gre/modules/commonjs/sdk/content/worker.js:24
I/Gecko   ( 5480): CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129
I/Gecko   ( 5480): @resource://gre/modules/commonjs/sdk/page-mod.js:12
I/Gecko   ( 5480): CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129
I/Gecko   ( 5480): @resource://youtube-e2l-at-jetpack/youtube-embed2link/lib/main.js:19
I/Gecko   ( 5480): CuddlefishLoader/options<.load@resource://gre/modules/commonjs/sdk/loader/cuddlefish.js:129
I/Gecko   ( 5480): run@resource://gre/modules/commonjs/sdk/addon/runner.js:146
I/Gecko   ( 5480): startup/

[kevincox]

Related bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=957038 https://bugzilla.mozilla.org/show_bug.cgi?id=969782

Closing as upstream problem. If this occurs with nightly please reopen.

[AlexVallat]

Fair enough, that looks pretty solidly their problem, and ought to be included in 30. Or even 29 with any luck, I wasn't clear on that bit.

[kevincox]

Yeah, I still have trouble finding out when things will land with Mozilla. I think it should be in 29 and it also sounds like it might make it in the 28 release build (probably not).

Anyways, thanks for making me aware of this, and thanks for the donation, it is much appreciated.

[kevincox]

My Firefox beta 28 just updated and everything appears to be working now.

[AlexVallat]

Confirmed, just installed the update here and it's working for me too. Thanks for the heads-up.