search

kevinelliott / agent_orange

Parse and process User Agents like a secret one
125 stars 36 forks source link

Trying to add a new bot #14

Open scottillogical opened 12 years ago

scottillogical commented 12 years ago

I have a simple spec

ua =  AgentOrange::UserAgent.new("Pingdom.com_bot_version_1.4_(http://www.pingdom.com/)" )
ua.is_bot?.should eql true

It returns false

I added

id_new_190610_333333 Pingdom.com_bot_version_1.4_(http://www.pingdom.com/) Pingdom bot R http://www.pingdom.com

To the end of the xml but it's still not correctly marking this as a bot.

What is the deal with the xml, how do I add a new bot to the list?

kevinelliott commented 12 years ago

Adding the details to the xml will only add it to the tests to check the parser against. In order to add support for this bot, it must be added to the library itself. I will look into this shortly.

kevinelliott commented 12 years ago

Try again with the improved bot detection. Let me know how things work for you.