search

kevinelliott / agent_orange

Parse and process User Agents like a secret one
126 stars 36 forks source link

10" Tablet devices reported as mobile, looking for advice #19

Open thuss opened 12 years ago

thuss commented 12 years ago

Thanks for the great work on agent_orange!

We're using it to detect mobile UA's on http://www.classmonkeys.com to serve users a mobile experience. The only issue we've run into is that 10" tablets which fall in the gray area between mobile phone and laptop (which we want to serve a desktop web experience to) are reported as mobile.

Is there some way we haven't thought of using agent orange to see if something is a tablet?

kevinelliott commented 12 years ago

Great question. I do think it would be good to identify tablets as tablets. I'll put some thought into this and implement a refactor. I'm glad you're finding agent_orange useful.

-Kevin

On May 25, 2012, at 1:40 PM, Todd Huss wrote:

Thanks for the great work on agent_orange!

We're using it to detect mobile UA's on http://www.classmonkeys.com to serve users a mobile experience. The only issue we've run into is that 10" tablets which fall in the gray area between mobile phone and laptop (which we want to serve a desktop web experience to) are reported as mobile.

Is there some way we haven't thought of using agent orange to see if something is a tablet?

Reply to this email directly or view it on GitHub: https://github.com/kevinelliott/agent_orange/issues/19

rjacoby commented 11 years ago

One case is the Samsung Galaxy Tab II, which Facebook treats as a mobile but does not broadcast a string that your regex would match.

Its agent we match for that case is 'GT-P3113'.

kevinelliott commented 11 years ago

This brings up an interesting issue. We should probably have an exceptions list that contains a specific regex and avoids the parsing chain, allowing you to set specific details. It might also be nice to add in the ability to easily add exceptions via config in your app so that the gem doesn't need to be modified to implement quick changes.

On Nov 30, 2012, at 8:39 AM, Rafi Jacoby notifications@github.com wrote:

One case is the Samsung Galaxy Tab II, which Facebook treats as a mobile but does not broadcast a string that your regex would match.

Its agent we match for that case is 'GT-P3113'.

— Reply to this email directly or view it on GitHub.