search

kevinelliott / agent_orange

Parse and process User Agents like a secret one
126 stars 36 forks source link

Added support for is_mobile? returning true for Google's smartphone crawler #24

Closed twobitlabs closed 11 years ago

twobitlabs commented 11 years ago

Google has both desktop and mobile crawlers:

https://developers.google.com/webmasters/smartphone-sites/googlebot-mobile

This change makes it so is_mobile? returns true AND is_bot? returns true for the Google smartphone crawler and includes specs for both the desktop and mobile user agent. I opted to stay backwards compatible for the standard Google crawler user agent so that is_computer? continues to return false.

kevinelliott commented 11 years ago

Looks good, I'll get this merged in shortly. Thanks for the contribution!

On Sep 14, 2012, at 4:01 PM, Two Bit Labs notifications@github.com wrote:

Google has both desktop and mobile crawlers:

https://developers.google.com/webmasters/smartphone-sites/googlebot-mobile

This change makes it so is_mobile? returns true AND is_bot? returns true for the Google smartphone crawler and includes specs for both the desktop and mobile user agent. I opted to stay backwards compatible for the standard Google crawler user agent so that is_computer? continues to return false.

You can merge this Pull Request by running:

git pull https://github.com/twobitlabs/agent_orange googleuseragents Or view, comment on, or merge it at:

https://github.com/kevinelliott/agent_orange/pull/24

Commit Summary

Added support for is_mobile? returning true on Google's mobile web File Changes

M lib/agent_orange/device.rb (14) M spec/user_agent_spec.rb (34) Patch Links

https://github.com/kevinelliott/agent_orange/pull/24.patch https://github.com/kevinelliott/agent_orange/pull/24.diff — Reply to this email directly or view it on GitHub.

kevinelliott commented 11 years ago

@thuss There were major changes in a PR previous to yours, and now this PR can no longer be automatically merged. Can you pull in develop and resubmit?

twobitlabs commented 11 years ago

I had also merged in Joe's changes so let me create a new feature branch and submit a new pull request.

kevinelliott commented 11 years ago

Oh that's makes sense. Thanks for doing that.

On Sep 24, 2012, at 4:01 PM, Two Bit Labs notifications@github.com wrote:

I had also merged in Joe's changes so let me create a new feature branch and submit a new pull request.

— Reply to this email directly or view it on GitHub.