search

kevinelliott / agent_orange

Parse and process User Agents like a secret one
126 stars 36 forks source link

Spec 'checking with real browsers list should parse browsers from list' failure #25

Closed kevinelliott closed 11 years ago

kevinelliott commented 11 years ago

1) AgentOrange::UserAgent checking with real browsers list should parse browsers from list Failure/Error: params[:browser_names].should include(br_name) expected ["Opera"] to include "MSIE"

./spec/long_user_agent_spec.rb:50:in `block (5 levels) in <top (required)>'

 # ./spec/long_user_agent_spec.rb:46:in`each'
 # ./spec/long_user_agent_spec.rb:46:in `block (4 levels) in <top (required)>'
 # ./spec/long_user_agent_spec.rb:21:in`each'
 # ./spec/long_user_agent_spec.rb:21:in `block (3 levels) in <top (required)>'
kevinelliott commented 11 years ago

@brain-geek Any chance you can take a look at this?

brain-geek commented 11 years ago

Hello, Kevin.

As I see, agent orange works right. It detects 'Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1' user-agent as IE, not opera.

Pull request: #27 .

kevinelliott commented 11 years ago

The PR submitted resolves the test failure correctly. Merged.