kevinelliott / agent_orange

Parse and process User Agents like a secret one
126 stars 36 forks source link

Improved Bot Detection #6

Closed joshuasiler closed 12 years ago

joshuasiler commented 12 years ago

Dramatically improved bot detection capabilities. Added rake test. Fixed some crashy bugs with nil values in some user_agents. Incremented gem version.

kevinelliott commented 12 years ago

Thanks for the improvements. Before I can merge this in, a few things need to be changed:

Please submit a new pull request once you've made the improvements above. I will have to manually merge since I've already merged in another pull request, but the change is quite minor.

I appreciate the contribution!

-Kevin

joshuasiler commented 12 years ago

Removed. Also cleaned up rake tasks as requested

davidjrice commented 12 years ago

Nice one, will give this a try. Will see if this improves things for Issue #3

joshuasiler commented 12 years ago

It's going to need a bit of a refactor to get any better. Right now it's only looking in parsed "comments" part of the string, which doesn't exist in all cases.

kevinelliott commented 12 years ago

Great job! Let me review the changes, make a few minor changes for consistency, and merge it in. Thanks guys.