fix(clientgen): add missing BorshPubkey import in defined types

[losman0s]

The BorshPubkey import is missing from the types1 generation for the generated client, leading to broken type structs. This addition should fix that.

[losman0s]

I have some local failures when running make test but I'm not certain they are related. One of them is due to the local validator teardown issues I have, and the other one is a cli test I don't have time to dig in preemptively. Would be great to have the CI fail before I invest time in this 👌

[kevinheavey]

Cool, the stuff that's failing now looks real

[losman0s]

Cool, the stuff that's failing now looks real

Yep, fixing the BarStruct in ts-reference/'s test program and corresponding test.

[kevinheavey]

Oh ts-reference is just a copy of anchor-client-gen using git subtree, don't bother changing that

[kevinheavey]

Ah but i see you need to change it to change the idl

hmm

[losman0s]

No worries I just changed whatever I found to test the change. I can make a test for this in a better place if you can point me to it 😄

[losman0s]

Or I can just scrap that. There is already some coverage in unit/test_clientgen.py.

[kevinheavey]

Yeah probably better to scrap it, I've been treating the subtree contents as read-only

[losman0s]

Makes sense, it'd become a merge nightmare otherwise. Changing.

[losman0s]

Done.

[kevinheavey]

thank you!