search

kevinhwang91 / rnvimr

Make Ranger running in a floating window to communicate with Neovim via RPC
BSD 3-Clause "New" or "Revised" License
800 stars 17 forks source link

fix: avoid spawning shell in termopen #114

Closed amerlyq closed 2 years ago

amerlyq commented 2 years ago

Convert termopen()/jobstart() arguments to List and pass Env as dict to avoid spawning intermediate shell.

Useful to reduce number of spawning processes and avoid executing default SHELL=zsh commands from zshenv on each startup.

Absence of shell spawn an be verified using sudo /usr/share/bcc/tools/execsnoop from bcc-tools.

kevinhwang91 commented 2 years ago

Good, but termopen with env is supported since nvim 0.5. However, I don't think a bump to 0.5 is a big deal, It's 2022 now. And I prefer Lua rather than Vimscript.