search

kevinjardine / polls

Polls for Elgg 1.8
11 stars 16 forks source link

add Russian localization #10

Closed tacid closed 11 years ago

tacid commented 11 years ago

also some deprecation fixes and added notifications about created polls

kevinjardine commented 11 years ago

This looks like good work but I don't want to change the default behaviour of the poll plugin without allowing people a chance to return to the previous behaviour. Could you add a poll plugin setting to turn on notications and make it on by default?

Then people who don't want notifications can turn it off.

kevinjardine commented 11 years ago

Also, in future can you split up your pull requests into single functional changes? I would have taken your first two commits immediately.

tacid commented 11 years ago

Thank you for the answer and a good advice. I've added option to turn on/off notification and in future I will try to split pull requests.

P.S. Thank you for your work on this plugin, I'm glad somehow contribute to it  :+1:

kevinjardine commented 11 years ago

Thank you!