search

kevinkhill / lavacharts

Lavacharts is a graphing / charting library for PHP 5.4+ that wraps Google's Javascript Chart API.
http://lavacharts.com
Other
619 stars 142 forks source link

Laravel5 support #30

Closed robert83ft closed 9 years ago

robert83ft commented 9 years ago

Hi

I might be wrong but I think it's not compatible with Laravel5.

I get

  [BadMethodCallException]
  Call to undefined method [package]

Script php artisan clear-compiled handling the post-update-cmd event returned with an error

  [RuntimeException]
  Error Output:

right after I add 'Khill\Lavacharts\Laravel\LavachartsServiceProvider', in app.php as instructed for Laravel.

Seems OK in Laravel4. Would you like to make it compatible with Laravel5?

kevinkhill commented 9 years ago

If you update to the most recent version, 2.0.5, you should have no problem. This was already addressed in issue #20

robert83ft commented 9 years ago

Well I used "khill\lavacharts" : "2.0.*" .. that means I was using latest ... Thanks for the reference to #20 ... it means it's simply something else .. specific to my project. I will digg deeper.

Thanks!!

kevinkhill commented 9 years ago

If it does still happen to be on my end, please let me know

robert83ft commented 9 years ago

I appreciate your help. If I don't figure it out .. I'll ask for more help later. I stopped looking deeper .. as it looked very much like it was not updated for L5 (got that in other packages as well) but it seems that's not the problem ;).

Robert

On 26 February 2015 at 17:49, Kevin Hill notifications@github.com wrote:

If it does still happen to be on my end, please let me know On Feb 26, 2015 7:48 AM, "Robert Rotter" notifications@github.com wrote:

Well I used "khill\lavacharts" : "2.0.*" .. that means I was using latest ... Thanks for the reference to #20 https://github.com/kevinkhill/lavacharts/issues/20 ... it means it's simply something else .. specific to my project. I will digg deeper.

Thanks!!

— Reply to this email directly or view it on GitHub < https://github.com/kevinkhill/lavacharts/issues/30#issuecomment-76201402>

.

— Reply to this email directly or view it on GitHub https://github.com/kevinkhill/lavacharts/issues/30#issuecomment-76201693 .

Robert Rotter

Manager

_smart_spot

m: +40 744 269743

d: +40 364 887698

e: robert@smartspot.ro robert@smartspot.ro

w: www.smartspot.ro http://www.smartspot.ro

robert83ft commented 9 years ago

When I re-tested today it suddenly worked fine. It must have been something specific to my project which was fixed in the meantime. I'm sorry I have wasted your time.

Thanks!!

kevinkhill commented 9 years ago

Don't worry, not a waste, I'm happy to help. Glad you fixed your problem On Feb 27, 2015 6:08 AM, "Robert Rotter" notifications@github.com wrote:

When I re-tested today it suddenly worked fine. It must have been something specific to my project which was fixed in the meantime. I'm sorry I have wasted your time.

Thanks!!

— Reply to this email directly or view it on GitHub https://github.com/kevinkhill/lavacharts/issues/30#issuecomment-76399305 .

thomthom commented 8 years ago

I ran into this myself today - upgrading and old L4 project via Laravel Shift.

When I remove lavachart from composer.php and app.php the error goes away. The moment I add them back I get errors:

C:\Users\Thomas\SourceTree\ErrorReporter (laravel-5.0-shift)
λ composer update
Warning: This development build of composer is over 60 days old. It is recommended to update it by running "C:\ProgramData\ComposerSetup\bin\composer.phar self-update" to get the latest version.
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing khill/lavacharts (2.0.5)
    Downloading: 100%

Writing lock file
Generating autoload files
> php artisan clear-compiled

  [BadMethodCallException]
  Call to undefined method [package]

Script php artisan clear-compiled handling the post-update-cmd event returned with an error

  [RuntimeException]
  Error Output:
thomthom commented 8 years ago

Updating the old 2.0.* to 2.5.* avoided the error.

kevinkhill commented 8 years ago

That is a very old version of Lavacharts, I would recommend trying the most recent version.

Require 3.0.* in your composer.json On Apr 30, 2016 12:18 PM, "Thomas Thomassen" notifications@github.com wrote:

I ran into this myself today - upgrading and old L4 project via Laravel Shift.

When I remove lavachart from composer.php and app.php the error goes away. The moment I add them back I get errors:

C:\Users\Thomas\SourceTree\ErrorReporter (laravel-5.0-shift) λ composer update Warning: This development build of composer is over 60 days old. It is recommended to update it by running "C:\ProgramData\ComposerSetup\bin\composer.phar self-update" to get the latest version. Loading composer repositories with package information Updating dependencies (including require-dev)

  • Installing khill/lavacharts (2.0.5) Downloading: 100%

Writing lock file Generating autoload files

php artisan clear-compiled

[BadMethodCallException] Call to undefined method [package]

Script php artisan clear-compiled handling the post-update-cmd event returned with an error

[RuntimeException] Error Output:

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/kevinkhill/lavacharts/issues/30#issuecomment-215988326

kevinkhill commented 8 years ago

You answered your own question before my answer, but I would recommend getting into the 3.0 branch, as it is under active development.

thomthom commented 8 years ago

Yes, I will most likely do that - but wanted to get a quick-fix to complete the Laravel migration before refactoring the lavachart code. Version 3 looks nice though. :)

kevinkhill commented 8 years ago

Good plan :smile: :+1: