search

kevinkhill / lavacharts

Lavacharts is a graphing / charting library for PHP 5.4+ that wraps Google's Javascript Chart API.
http://lavacharts.com
Other
619 stars 142 forks source link

Google Charts version "current" is breaking things #330

Closed kevinkhill closed 4 years ago

kevinkhill commented 4 years ago

The problem is related to an attribute called "isHtml". Since there is no occurrence of this attribute in any file in this repository, I assume that the error was generated by the Google Charts library itself.

That way, as suggested by @daveblake, replacing the "current" version with a specific frozen version, we were able to solve the problem.

Given that the latest frozen version of Google Charts was released in May 2020 (48) and it is generating the error, it would be appropriate to specify the latest compatible version, which 47

So, I believe that replacing the line that defines the version to be loaded, is enough to solve the problem.

In /javascript/dist/lava.js:

google.charts.load ('current', config);

switch to:

google.charts.load ('47 ', config);

Originally posted by @jordankobellarz in https://github.com/kevinkhill/lavacharts/issues/326#issuecomment-633091453

kevinkhill commented 4 years ago

@daveblake @jordankobellarz

kevinkhill commented 4 years ago

329 #328

fotonmoton commented 4 years ago

@kevinkhill, can you release new version so your changes can be fetched via simple package update? Otherwise we should patch this bug ourselves by hand. Thanks for discovering real cause of the bug 👍

kevinkhill commented 4 years ago

Tagged & Updated :smiley: