Added phpstan and fixed issues till level 6

kevinkhill / php-duration

Convert durations of time between colon-formatted, human-readable, and seconds

MIT License

158 stars 26 forks source link

Added phpstan and fixed issues till level 6 #24

Closed artoroz closed 3 years ago

artoroz commented 3 years ago

Added phpstan to the project #16
Deprecated all php 5.x versions since they haven't had security updates in a while (prefer to deprecate 7.0 and 7.1 as well but that's up to you)
Added php 8 as check in travis
Removed returnUnsigned argument on numberBreakdown, since this is a private method and the argument is not used in the code
Fixed all issues up to level 6

kevinkhill commented 3 years ago

YOU RULE! I haven't been tending my PHP projects in a while.... I didn't even know PHP8 was on its way? I officially procrastinated an entire version! XD

artoroz commented 3 years ago

Thanks, do you mind making a new release for all the features since? https://github.com/kevinkhill/php-duration/compare/1.0.6...master

kevinkhill commented 3 years ago

Your wish is my command!