search

kevinlacaille / planet_hack_2020_deforestation

Related Project Pitch: https://github.com/planetlabs-community/planet-hack-2020/issues/64
2 stars 4 forks source link

Provide a way to give Planet API key #14

Closed guy1ziv2 closed 4 years ago

guy1ziv2 commented 4 years ago

Currently uses PL_API_KEY environmental variable, make it accept API key as parameter in redirect. It is probably better not to stored ANY API keys with the App

gilles-morain commented 4 years ago

Not sure the alternative is better: would you let an API key in a Google Sheet document ? We can however have an overload option so if you want the app to search with your own key when manually interrogating the API that's doable for sure. I still think the app needs a default API key hidden from the Google Sheet users

guy1ziv2 commented 4 years ago

Yes, I see your point.

On Sat, 17 Oct 2020, 18:23 Gilles Morain, notifications@github.com wrote:

Not sure the alternative is better: would you let an API key in a Google Sheet document ? We can however have an overload option so if you want the app to search with your own key when manually interrogating the API that's doable for sure. I still think the app needs a default API key hidden from the Google Sheet users

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinlacaille/planet_hack_2020_deforestation/issues/14#issuecomment-711052095, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP66OYXEY6DDRXO3WU2WF3SLHHKPANCNFSM4SUPLMRQ .

gilles-morain commented 4 years ago

Added a /setenv?PL_API_KEY=<...> route that can be enabled using the SETENV_ENABLED config parameter, but this effectively replaces the key used globally by the app in commit cdc4432dbaf9eef21ba2aafb1f3bce6ed19ecf7f