search

kevinlekiller / mkvrg

Apply replaygain tags to matroska files without remuxing (gain is calculated using ffmpeg and tags are applied using mkvpropedit).
GNU General Public License v2.0
9 stars 2 forks source link

Bug: Non-mkv Files specified as arguments that get remuxed don't get filtered #16

Open WhitePeter opened 6 months ago

WhitePeter commented 6 months ago

I just found out that non-mkv files that are passed as arguments will not have the resulting remuxed file filtered/tagged. The reason is that the find command only uses the argument list $@ as starting points, and because the corresponding mkv-file is not in that list it will get passed over.

WhitePeter commented 6 months ago

For now, the fix is in the less_bash branch but it shouldn't be too hard to do similarly on master, I am just not in the mood right now. ;-)

BTW, that new function is basically all that needs to remain of the functionality, IMHO. Only take a list of files, or maybe even just one, as argument(s) and do away with the "recursive" mode, as suggested in PR #12. Maybe remuxing can stay, but I don't really see the point. mkvrg is in the tagging business and should stay in its lane. ;-) Do one thing.