search

kevinlekiller / reshade-steam-proton

Easy setup and updating of ReShade on Linux for games using wine or proton.
GNU General Public License v2.0
361 stars 19 forks source link

Mark `reshade-steam-proton.sh` as executable #20

Closed Calinou closed 1 year ago

Calinou commented 1 year ago

Unlike reshade-linux.sh, reshade-steam-proton.sh wasn't marked as executable. This made it impossible to run unless you ran chmod +x on it before or ran it with bash reshade-steam-proton.sh.

kevinlekiller commented 1 year ago

Is it possible to set it to 100744 (aka -rwxr--r--) ? or is 100755 a limition of git ?

kevinlekiller commented 1 year ago

Also you can edit these to remove adding user executable:

https://github.com/kevinlekiller/reshade-steam-proton/blob/main/README.md#usage

https://github.com/kevinlekiller/reshade-steam-proton/blob/main/reshade-linux.sh#L64

Calinou commented 1 year ago

Is it possible to set it to 100744 (aka -rwxr--r--) ? or is 100755 a limition of git ?

With Git 2.36.1, it looks like chmod 744 can't be stored in Git, only 644 and 755.

Also you can edit these to remove adding user executable:

The README step needs to be kept, as curling a file will not carry over the executable flag. Cloning a repository will carry over this flag, and so does extracting a ZIP archive (depending on how it was made). I'd also keep the step listed in the script itself just in case.

kevinlekiller commented 1 year ago

Sounds good, will merge, thanks!