kevinlu1248 / CoralME

A simple, fast and garbage-free matching engine order book that you can use as a starting point for your matching engines.
Apache License 2.0
0 stars 0 forks source link

Refactor Enums in Order.java to Separate Files a #3

Open kevinlu1248 opened 12 hours ago

kevinlu1248 commented 12 hours ago

Purpose Refactoring enums in Order.java to separate files involves moving each enum type (like TimeInForce, RejectReason, etc.) into its own Java file. This change is meant to:

Improve Code Organization: By having each enum in its own file, the codebase becomes more organized, making it easier to locate and understand each enum. Enhance Maintainability: With enums in separate files, it becomes simpler to manage and update them individually without affecting other parts of the code. Simplify Imports: Instead of dealing with a large Order.java file, you can import only the specific enums you need, which can make the code cleaner. Description The changes in this pull request involve:

Create New Files: For each enum in Order.java, create a new file in the same package (com.coralblocks.coralme). Move Enum Code: Copy the enum definition from Order.java to the respective new file. Update References: Go through the entire codebase and update the import statements to point to the new locations of these enums. Test: Ensure the project compiles correctly and all tests pass, verifying that the changes did not introduce any errors. Summary The key changes in this pull request are:

TimeInForce, RejectReason, CancelRejectReason, CancelReason, ReduceRejectReason, Type, ExecuteSide, and Side enums moved to separate files Import statements in affected files updated to use the new enum files Comprehensive testing to ensure the changes did not introduce any regressions Fixes https://github.com/dakotahNorth/CoralME/issues/8. Continue the conversation here: http://localhost:3000/c/b2dc4508-5b52-4618-a386-3b404f6c52b5.

To have Sweep make further changes, please add a comment to this PR starting with "Sweep:".

📖 For more information on how to use Sweep, please read our documentation.