kevinlu1248 / armbian-build

The Armbian Linux Build Framework under Kreyren's Management
GNU General Public License v2.0
0 stars 0 forks source link

Sweep: Remove useless square brackets #1

Open kevinlu1248 opened 1 year ago

kevinlu1248 commented 1 year ago

Currently the codebase is using if [[ -n "${BOARD}" ]]; then .. and alike where the double square brackets as they indicate the use of bash where this could be done from posix sh with if [ -n "${BOARD}" ]; then ..

Try to address that

sweep-nightly[bot] commented 1 year ago

Here's the PR! https://github.com/kevinlu1248/armbian-build/pull/2.

💎 Sweep Pro: I used GPT-4 to create this ticket. You have unlimited GPT-4 tickets. To retrigger Sweep, edit the issue.


Step 1: 📍 Planning

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/lib/functions/artifacts/artifact-rootfs.sh#L205-L167 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/lib/functions/artifacts/artifact-rootfs.sh#L175-L167 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/packages/bsp/h3disp#L85-L215 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/lib/functions/configuration/interactive.sh#L145-L267 https://github.com/kevinlu1248/armbian-build/blob/e13c915efd6b71179224c064bd1c07fbbcb8b81b/lib/functions/main/config-prepare.sh#L145-L335

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/remove-double-square-brackets.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord