This PR replaces all instances of the outdated 'x-hack' in the codebase with a more modern and reliable approach for checking variable values. The 'x-hack' is a shell/bash conditional that uses the letter 'x' followed by a variable declaration and checks against the same letter followed by a value. This practice was used to ensure compatibility across different shells and systems, but it is now considered obsolete due to the evolution of modern shells.
The following changes were made in this PR:
Replaced all instances of the 'x-hack' in packages/bsp/nanopim4/nanopim4-pwm-fan.sh
Replaced all instances of the 'x-hack' in packages/blobs/grub/09_linux_with_dtb.sh
Replaced all instances of the 'x-hack' in lib/tools/shellcheck.sh
Replaced all instances of the 'x-hack' in lib/functions/artifacts/artifact-firmware.sh
Replaced all instances of the 'x-hack' in lib/functions/artifacts/artifacts-reversion.sh
Summary
The 'x-hack' was replaced with a more modern approach for checking variable values, specifically [ "${var}" = "val" ]. This change improves the reliability of the code and ensures compatibility with modern shells.
Fixes #4.
š Latest improvements to Sweep:
Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE
š” To get Sweep to edit this pull request, you can:
Leave a comment below to get Sweep to edit the entire PR
Leave a comment in the code will only modify the file
Edit the original issue to get Sweep to recreate the PR from scratch
Description
This PR replaces all instances of the outdated 'x-hack' in the codebase with a more modern and reliable approach for checking variable values. The 'x-hack' is a shell/bash conditional that uses the letter 'x' followed by a variable declaration and checks against the same letter followed by a value. This practice was used to ensure compatibility across different shells and systems, but it is now considered obsolete due to the evolution of modern shells.
The following changes were made in this PR:
packages/bsp/nanopim4/nanopim4-pwm-fan.shpackages/blobs/grub/09_linux_with_dtb.shlib/tools/shellcheck.shlib/functions/artifacts/artifact-firmware.shlib/functions/artifacts/artifacts-reversion.shSummary
The 'x-hack' was replaced with a more modern approach for checking variable values, specifically [ "${var}" = "val" ]. This change improves the reliability of the code and ensures compatibility with modern shells.
Fixes #4.
š Latest improvements to Sweep:
š” To get Sweep to edit this pull request, you can: