This PR removes the usage of 'x-hack' in the grub and bsp packages of the armbian-build repository. The 'x-hack' is a common practice in shell scripting for string comparison to avoid syntax errors when one of the variables is empty or unset. However, it is not necessary when using the double bracket conditional construct [[ ]], which can handle empty variables. The 'x-hack' comparisons have been replaced with direct comparisons using double brackets [[ ]].
Summary of Changes
In packages/bsp/nanopim4/nanopim4-pwm-fan.sh, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].
In packages/blobs/grub/09_linux_with_dtb.sh, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].
Please review the changes and merge this PR if it meets the requirements. Thank you!
Fixes #19.
š Latest improvements to Sweep:
Getting Sweep to run linters before committing! Check out Sweep Sandbox Configs to set it up.
Added support for self-hosting! Check out Self-hosting Sweep to get started.
[Self Hosting] Multiple options to compute vector embeddings, configure your .env file using VECTOR_EMBEDDING_SOURCE
š” To get Sweep to edit this pull request, you can:
Leave a comment below to get Sweep to edit the entire PR
Leave a comment in the code will only modify the file
Edit the original issue to get Sweep to recreate the PR from scratch
Description
This PR removes the usage of 'x-hack' in the grub and bsp packages of the armbian-build repository. The 'x-hack' is a common practice in shell scripting for string comparison to avoid syntax errors when one of the variables is empty or unset. However, it is not necessary when using the double bracket conditional construct [[ ]], which can handle empty variables. The 'x-hack' comparisons have been replaced with direct comparisons using double brackets [[ ]].
Summary of Changes
packages/bsp/nanopim4/nanopim4-pwm-fan.sh, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].packages/blobs/grub/09_linux_with_dtb.sh, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].Please review the changes and merge this PR if it meets the requirements. Thank you!
Fixes #19.
š Latest improvements to Sweep:
š” To get Sweep to edit this pull request, you can: